Suggest using integration tests for test crate using own proc-macro #110255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
clubby789
changed the title
|
This needs a test. Not exactly sure the best way to write one. |
clubby789
force-pushed
the
proc-macro-test-help
branch
from
1aa85ce to
f7581d8
Compare
|
Added a test |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 23, 2023
…jackh726 Suggest using integration tests for test crate using own proc-macro cc rust-lang#110247
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 24, 2023
…jackh726 Suggest using integration tests for test crate using own proc-macro cc rust-lang#110247
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110255 (Suggest using integration tests for test crate using own proc-macro) - rust-lang#110514 (Remove `find_map_relevant_impl`) - rust-lang#110566 (Don't create projection ty for const projection) - rust-lang#110637 (Group some sections of our logs in github actions) - rust-lang#110706 (Add `intrinsics::transmute_unchecked`) - rust-lang#110714 (Normalize types and consts in MIR opts.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #110247